lkml.org 
[lkml]   [2011]   [Aug]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 41/41] exit: Use __set_task_blocked()
    On 08/11, Matt Fleming wrote:
    >
    > As described in e6fa16ab ("signal: sigprocmask() should do
    > retarget_shared_pending()") the modification of current->blocked is
    > incorrect as we need to check whether the signal we're about to block
    > is pending in the shared queue.

    Yes. but in this case the code is correct. First of all, unblocking
    is always fine. Also, this should be used by kthreads only, and they
    are single-threaded.

    But there are other reasons why I don't like this change, even if we
    ignore the fact the patched exit.c can't be compiled (__set_task_blocked
    is not exported ;).

    > int allow_signal(int sig)
    > {
    > + sigset_t blocked;
    > +
    > if (!valid_signal(sig) || sig < 1)
    > return -EINVAL;
    >
    > spin_lock_irq(&current->sighand->siglock);
    > /* This is only needed for daemonize()'ed kthreads */

    Exactly. And nowadays the daemonize()'ed kthreads should not play
    with allow_signal().

    And more, I think it is the time to kill daemonize(). Contrary to
    what /bin/grep thinks, it has only one user.

    In short: this code in allow_signal() should die. I'll try to send
    the patches soon...

    Oleg.



    \
     
     \ /
      Last update: 2011-08-16 20:13    [W:0.021 / U:62.076 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site