lkml.org 
[lkml]   [2011]   [Aug]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
Subject[PATCH 0/1] kthreads: allow_signal: don't play with ->blocked
On 08/16, Oleg Nesterov wrote:
>
> > int allow_signal(int sig)
> > {
> > + sigset_t blocked;
> > +
> > if (!valid_signal(sig) || sig < 1)
> > return -EINVAL;
> >
> > spin_lock_irq(&current->sighand->siglock);
> > /* This is only needed for daemonize()'ed kthreads */
>
> Exactly. And nowadays the daemonize()'ed kthreads should not play
> with allow_signal().
>
> And more, I think it is the time to kill daemonize(). Contrary to
> what /bin/grep thinks, it has only one user.

No, daemonize() has no users which actually need it.

Imho we should deprecate it, it has no users after the patches I sent.

> In short: this code in allow_signal() should die.

Yes.

To clarify: this change breaks drivers/staging/rtl8712/, but I belive
it is wrong and should be fixed. I have already sent the patch.

Oleg.



\
 
 \ /
  Last update: 2011-08-16 21:49    [W:0.077 / U:1.720 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site