Messages in this thread | | | Date | Wed, 8 Sep 2010 08:15:28 +0200 | From | Johannes Weiner <> | Subject | Re: [PATCH 04/10] vmscan: Synchronous lumpy reclaim should not call congestion_wait() |
| |
On Mon, Sep 06, 2010 at 11:47:27AM +0100, Mel Gorman wrote: > From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> > > congestion_wait() mean "waiting queue congestion is cleared". However, > synchronous lumpy reclaim does not need this congestion_wait() as > shrink_page_list(PAGEOUT_IO_SYNC) uses wait_on_page_writeback() > and it provides the necessary waiting. > > Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> > Signed-off-by: Mel Gorman <mel@csn.ul.ie>
Reviewed-by: Johannes Weiner <hannes@cmpxchg.org>
> --- > mm/vmscan.c | 2 -- > 1 files changed, 0 insertions(+), 2 deletions(-) > > diff --git a/mm/vmscan.c b/mm/vmscan.c > index eabe987..5979850 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -1341,8 +1341,6 @@ shrink_inactive_list(unsigned long nr_to_scan, struct zone *zone, > > /* Check if we should syncronously wait for writeback */ > if (should_reclaim_stall(nr_taken, nr_reclaimed, priority, sc)) { > - wait_iff_congested(zone, BLK_RW_ASYNC, HZ/10); > - > /* > * The attempt at page out may have made some > * of the pages active, mark them inactive again.
| |