lkml.org 
[lkml]   [2010]   [Jul]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[patch 004/149] NFSD: dont report compiled-out versions as present
    2.6.32-stable review patch.  If anyone has any objections, please let us know.

    ------------------

    From: Pavel Emelyanov <xemul@openvz.org>

    commit 15ddb4aec54422ead137b03ea4e9b3f5db3f7cc2 upstream.

    The /proc/fs/nfsd/versions file calls nfsd_vers() to check whether
    the particular nfsd version is present/available. The problem is
    that once I turn off e.g. NFSD-V4 this call returns -1 which is
    true from the callers POV which is wrong.

    The proposal is to report false in that case.

    The bug has existed since 6658d3a7bbfd1768 "[PATCH] knfsd: remove
    nfsd_versbits as intermediate storage for desired versions".

    Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
    Acked-by: NeilBrown <neilb@suse.de>
    Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    fs/nfsd/nfssvc.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/fs/nfsd/nfssvc.c
    +++ b/fs/nfsd/nfssvc.c
    @@ -136,7 +136,7 @@ u32 nfsd_supported_minorversion;
    int nfsd_vers(int vers, enum vers_op change)
    {
    if (vers < NFSD_MINVERS || vers >= NFSD_NRVERS)
    - return -1;
    + return 0;
    switch(change) {
    case NFSD_SET:
    nfsd_versions[vers] = nfsd_version[vers];



    \
     
     \ /
      Last update: 2010-07-01 20:57    [W:0.019 / U:31.072 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site