lkml.org 
[lkml]   [2010]   [Jul]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[06/23] powerpc/oprofile: fix potential buffer overrun in op_model_cell.c
    2.6.27-stable review patch.  If anyone has any objections, please let us know.

    ------------------

    From: Denis Kirjanov <dkirjanov@hera.kernel.org>

    commit 238c1a78c957f3dc7cb848b161dcf4805793ed56 upstream.

    Fix potential initial_lfsr buffer overrun.
    Writing past the end of the buffer could happen when index == ENTRIES

    Signed-off-by: Denis Kirjanov <dkirjanov@kernel.org>
    Signed-off-by: Robert Richter <robert.richter@amd.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    arch/powerpc/oprofile/op_model_cell.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/arch/powerpc/oprofile/op_model_cell.c
    +++ b/arch/powerpc/oprofile/op_model_cell.c
    @@ -821,7 +821,7 @@ static int calculate_lfsr(int n)
    index = ENTRIES-1;

    /* make sure index is valid */
    - if ((index > ENTRIES) || (index < 0))
    + if ((index >= ENTRIES) || (index < 0))
    index = ENTRIES-1;

    return initial_lfsr[index];



    \
     
     \ /
      Last update: 2010-07-01 20:13    [W:0.043 / U:2.000 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site