lkml.org 
[lkml]   [2010]   [Jul]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[165/200] tracing: Fix null pointer deref with SEND_SIG_FORCED
    2.6.34-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Oleg Nesterov <oleg@redhat.com>

    commit b9b76dfaac6fa2c289ee8a005be637afd2da7e2f upstream.

    BUG: unable to handle kernel NULL pointer dereference at
    0000000000000006
    IP: [<ffffffff8107bd37>] ftrace_raw_event_signal_generate+0x87/0x140

    TP_STORE_SIGINFO() forgets about SEND_SIG_FORCED, fix.

    We should probably export is_si_special() and change TP_STORE_SIGINFO()
    to use it in the longer term.

    Signed-off-by: Oleg Nesterov <oleg@redhat.com>
    Acked-by: Roland McGrath <roland@redhat.com>
    Cc: Steven Rostedt <rostedt@goodmis.org>
    Cc: Andrew Morton <akpm@linux-foundation.org>
    Cc: Jason Baron <jbaron@redhat.com>
    Cc: Masami Hiramatsu <mhiramat@redhat.com>
    LKML-Reference: <20100603213409.GA8307@redhat.com>
    Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    include/trace/events/signal.h | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    --- a/include/trace/events/signal.h
    +++ b/include/trace/events/signal.h
    @@ -10,7 +10,8 @@

    #define TP_STORE_SIGINFO(__entry, info) \
    do { \
    - if (info == SEND_SIG_NOINFO) { \
    + if (info == SEND_SIG_NOINFO || \
    + info == SEND_SIG_FORCED) { \
    __entry->errno = 0; \
    __entry->code = SI_USER; \
    } else if (info == SEND_SIG_PRIV) { \



    \
     
     \ /
      Last update: 2010-07-01 23:37    [W:0.024 / U:34.292 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site