[lkml]   [2010]   [Dec]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    Subject[PATCH] [63/223] percpu: fix list_head init bug in __percpu_counter_init()
    2.6.35-longterm review patch.  If anyone has any objections, please let me know.

    From: Masanori ITOH <>

    commit 8474b591faf3bb0a1e08a60d21d6baac498f15e4 upstream.

    WARNING: at lib/list_debug.c:26 __list_add+0x3f/0x81()
    Hardware name: Express5800/B120a [N8400-085]
    list_add corruption. next->prev should be prev (ffffffff81a7ea00), but was dead000000200200. (next=ffff88080b872d58).
    Modules linked in: aoe ipt_MASQUERADE iptable_nat nf_nat autofs4 sunrpc bridge 8021q garp stp llc ipv6 cpufreq_ondemand acpi_cpufreq freq_table dm_round_robin dm_multipath kvm_intel kvm uinput lpfc scsi_transport_fc igb ioatdma scsi_tgt i2c_i801 i2c_core dca iTCO_wdt iTCO_vendor_support pcspkr shpchp megaraid_sas [last unloaded: aoe]
    Pid: 54, comm: events/3 Tainted: G W 2.6.34-vanilla1 #1
    Call Trace:
    [<ffffffff8104bd77>] warn_slowpath_common+0x7c/0x94
    [<ffffffff8104bde6>] warn_slowpath_fmt+0x41/0x43
    [<ffffffff8120fd2e>] __list_add+0x3f/0x81
    [<ffffffff81212a12>] __percpu_counter_init+0x59/0x6b
    [<ffffffff810d8499>] bdi_init+0x118/0x17e
    [<ffffffff811f2c50>] blk_alloc_queue_node+0x79/0x143
    [<ffffffff811f2d2b>] blk_alloc_queue+0x11/0x13
    [<ffffffffa02a931d>] aoeblk_gdalloc+0x8e/0x1c9 [aoe]
    [<ffffffffa02aa655>] aoecmd_sleepwork+0x25/0xa8 [aoe]
    [<ffffffff8106186c>] worker_thread+0x1a9/0x237
    [<ffffffffa02aa630>] ? aoecmd_sleepwork+0x0/0xa8 [aoe]
    [<ffffffff81065827>] ? autoremove_wake_function+0x0/0x39
    [<ffffffff810616c3>] ? worker_thread+0x0/0x237
    [<ffffffff810653ad>] kthread+0x7f/0x87
    [<ffffffff8100aa24>] kernel_thread_helper+0x4/0x10
    [<ffffffff8106532e>] ? kthread+0x0/0x87
    [<ffffffff8100aa20>] ? kernel_thread_helper+0x0/0x10

    It's because there is no initialization code for a list_head contained in
    the struct backing_dev_info under CONFIG_HOTPLUG_CPU, and the bug comes up
    when block device drivers calling blk_alloc_queue() are used. In case of
    me, I got them by using aoe.

    Signed-off-by: Masanori Itoh <>
    Cc: Tejun Heo <>
    Signed-off-by: Andrew Morton <>
    Signed-off-by: Linus Torvalds <>
    Signed-off-by: Greg Kroah-Hartman <>
    Signed-off-by: Andi Kleen <>

    lib/percpu_counter.c | 1 +
    1 file changed, 1 insertion(+)

    Index: linux/lib/percpu_counter.c
    --- linux.orig/lib/percpu_counter.c
    +++ linux/lib/percpu_counter.c
    @@ -76,6 +76,7 @@ int __percpu_counter_init(struct percpu_
    if (!fbc->counters)
    return -ENOMEM;
    + INIT_LIST_HEAD(&fbc->list);
    list_add(&fbc->list, &percpu_counters);

     \ /
      Last update: 2010-12-13 01:23    [W:0.023 / U:1.604 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site