[lkml]   [2010]   [Dec]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[PATCH] [178/223] mmc: fix rmmod race for hosts using card-detection polling
2.6.35-longterm review patch.  If anyone has any objections, please let me know.

From: Guennadi Liakhovetski <>

commit d9bcbf343ec63e1104b5276195888ee06b4d086f upstream.

MMC hosts that poll for card detection by defining the MMC_CAP_NEEDS_POLL
flag have a race on rmmod, where the delayed work is cancelled without
waiting for completed polling. To prevent this a _sync version of the work
cancellation has to be used.

Signed-off-by: Guennadi Liakhovetski <>
Signed-off-by: Chris Ball <>
Signed-off-by: Greg Kroah-Hartman <>
Signed-off-by: Andi Kleen <>

drivers/mmc/core/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux/drivers/mmc/core/core.c
--- linux.orig/drivers/mmc/core/core.c
+++ linux/drivers/mmc/core/core.c
@@ -1160,7 +1160,7 @@ void mmc_stop_host(struct mmc_host *host

if (host->caps & MMC_CAP_DISABLE)
- cancel_delayed_work(&host->detect);
+ cancel_delayed_work_sync(&host->detect);

/* clear pm flags now and let card drivers set them as needed */

 \ /
  Last update: 2010-12-13 00:59    [W:0.415 / U:3.204 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site