| From | Andi Kleen <> | Subject | [PATCH] [189/223] Staging: samsung-laptop: fix up my fixup for some sysfs attribute permissions | Date | Mon, 13 Dec 2010 00:48:14 +0100 (CET) |
| |
2.6.35-longterm review patch. If anyone has any objections, please let me know.
------------------ From: Greg Kroah-Hartman <gregkh@suse.de>
commit 4d7bc388b44e42a1feafa35e50eef4f24d6ca59d upstream.
They should be writable by root, not readable. Doh, stupid me with the wrong flags.
Reported-by: Jonathan Cameron <jic23@cam.ac.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> Signed-off-by: Andi Kleen <ak@linux.intel.com>
--- drivers/staging/samsung-laptop/samsung-laptop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux/drivers/staging/samsung-laptop/samsung-laptop.c =================================================================== --- linux.orig/drivers/staging/samsung-laptop/samsung-laptop.c +++ linux/drivers/staging/samsung-laptop/samsung-laptop.c @@ -356,7 +356,7 @@ static ssize_t set_silent_state(struct d } return count; } -static DEVICE_ATTR(silent, S_IRUSR | S_IRUGO, +static DEVICE_ATTR(silent, S_IWUSR | S_IRUGO, get_silent_state, set_silent_state);
|