lkml.org 
[lkml]   [2008]   [Sep]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 0/18] linux infrared remote control drivers
Date
On Tuesday 09 September 2008 09:06:03 Alexey Dobriyan wrote:
>
> All version.h and autoconf.h inclusions aren't needed.

I'll remove them.

> #ifdef MODULE is gross and very old. Don't need that. Just use
>
> static int __init x_init(void)
> {
> ...
> }
>
> static void __exit x_exit(void)
> {
> ...
> }
> module_init(x_init);
> module_exit(x_exit);
> MODULE_LICENSE
> ...
>
> It will work correctly in modular and built-in case.

Will do so.

> Static number of devices is simple but how about adding them
> dynamically.

Will have a look

Janne


\
 
 \ /
  Last update: 2008-09-09 10:43    [W:0.559 / U:3.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site