lkml.org 
[lkml]   [2008]   [Sep]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 08/18] lirc driver for the Soundgraph IMON IR Receivers
Date
On Wednesday 10 September 2008 17:23:51 Janne Grunau wrote:
> On Wednesday 10 September 2008 23:02:29 Jonathan Corbet wrote:
> > > +#define SUCCESS 0
> > > +#define TRUE 1
> > > +#define FALSE 0
> >
> > (See my grumble in previous reviews...:)
> >
> > > +#define LOCK_CONTEXT mutex_lock(&context->lock)
> > > +#define UNLOCK_CONTEXT mutex_unlock(&context->lock)
> >
> > Here too.
> >
> > > +/* to prevent races between open() and disconnect() */
> > > +static DECLARE_MUTEX(disconnect_sem);
> >
> > This should be a real mutex, I think.
>
> All three already resolved. I think it would wise to stop the review of
> this patch set until we repost or review based on Jarod's git
> repository (http://git.wilsonet.com/linux-2.6-lirc.git/).

Yeah, I'd say for any driver that hasn't yet been reviewed, if anyone wants to
continue reviewing, it might be best to poke the version in that git tree, as
a number of issues common across multiple drivers have already (hopefully)
been whacked. We'll definitely put together an updated patch set in the near
future, but at the moment, we're still working through all the bits that have
received feedback so far.

> Thanks for the reviews so far.

Indeed, very much appreciated!

--
Jarod Wilson
jarod@redhat.com



\
 
 \ /
  Last update: 2008-09-11 05:27    [W:0.068 / U:0.360 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site