lkml.org 
[lkml]   [2008]   [Sep]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 08/18] lirc driver for the Soundgraph IMON IR Receivers
Date
On Wednesday 10 September 2008 23:02:29 Jonathan Corbet wrote:
> > +#define SUCCESS 0
> > +#define TRUE 1
> > +#define FALSE 0
>
> (See my grumble in previous reviews...:)
>
> > +#define LOCK_CONTEXT mutex_lock(&context->lock)
> > +#define UNLOCK_CONTEXT mutex_unlock(&context->lock)
>
> Here too.
>
> > +/* to prevent races between open() and disconnect() */
> > +static DECLARE_MUTEX(disconnect_sem);
>
> This should be a real mutex, I think.

All three already resolved. I think it would wise to stop the review of
this patch set until we repost or review based on Jarod's git
repository (http://git.wilsonet.com/linux-2.6-lirc.git/).

Thanks for the reviews so far.

Janne


\
 
 \ /
  Last update: 2008-09-10 23:27    [W:0.509 / U:1.596 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site