lkml.org 
[lkml]   [2008]   [Sep]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 01/18] lirc core device driver infrastructure
On Wed, Sep 10, 2008 at 02:24:36PM +0200, Janne Grunau wrote:
> On Tuesday 09 September 2008 15:01:02 Christoph Hellwig wrote:
>
> > > + do {
> > > + if (ir->open) {
> > > + if (ir->jiffies_to_wait) {
> > > + set_current_state(TASK_INTERRUPTIBLE);
> > > + schedule_timeout(ir->jiffies_to_wait);
> > > + } else {
> > > + interruptible_sleep_on(
> > > + ir->p.get_queue(ir->p.data));
> > > + }
> >
> > No sleep on, please. But this one should be trivial to fix anyway,
> > by just changing this to a
> >
> > set_current_state(TASK_INTERRUPTIBLE);
> > schedule();
> >
> > and using wake_up_process in the wakeup path.
>
> No driver uses the get_queue callback. So I'm inclined to just remove
> it. Christoph, any objections?

Sounds good.


\
 
 \ /
  Last update: 2008-09-10 14:33    [W:0.174 / U:3.236 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site