lkml.org 
[lkml]   [2008]   [Sep]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 01/18] lirc core device driver infrastructure
* Janne Grunau | 2008-09-09 11:53:48 [+0200]:

>> >+
>> >+ bytes_in_key = p->code_length/8 + (p->code_length%8 ? 1 : 0);
>>
>> did you actually pass checkpatch.pl ?
>
>yes, and while this is ugly I see no obvious CodingStyle violation.
>
>is following better?
>
>bytes_in_key = p->code_length/8;
>if (p->code_length%8)
> bytes_in_key++;
>
bytes_in_key = p->code_length / 8;
if (p->code_length % 8)
bytes_in_key++;

I meant the missing spaces around / and %. Looking now at it, it seems
that it behaves like DIV_ROUND_UP(). The magic of spaces :)

>
>Janne

Sebastian


\
 
 \ /
  Last update: 2008-09-09 14:35    [W:0.180 / U:0.260 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site