| Date | Tue, 21 Feb 2012 14:58:57 +0100 | Subject | Re: [PATCH 13/20] pinctrl: Error if mapping table's control dev can't be found | From | Linus Walleij <> |
| |
On Mon, Feb 20, 2012 at 7:45 AM, Stephen Warren <swarren@nvidia.com> wrote:
> This is a serious error, and the pin control system will not function > correctly if it ends up not programing the mapping table entries into > the HW. Instead of just ignoring this, error out. > > Signed-off-by: Stephen Warren <swarren@nvidia.com>
Thanks applied, this came to bite me today so I see the value of being strict here.
> + /* Eventually, this should trigger deferred probe */ > + return -ENODEV;
I changed this to ERR_PTR(-ENODEV) in my codebase as it returns a pointer.
Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|