Messages in this thread | | | Date | Wed, 22 Feb 2012 14:56:48 +0800 | From | Dong Aisheng <> | Subject | Re: [PATCH 11/20] pinctrl: Downgrade pinctrl_get warning when no maps are found |
| |
On Tue, Feb 21, 2012 at 02:51:55PM +0100, Linus Walleij wrote: > On Mon, Feb 20, 2012 at 7:45 AM, Stephen Warren <swarren@nvidia.com> wrote: > > > This may be perfectly legitimate. An IP block may get re-used > > across SoCs. Not all of those SoCs may need pinmux settings for the > > IP block, e.g. if one SoC dedicates pins to that function but > > another doesn't. The driver won't know this, and will always > > attempt to set up the pinmux. The mapping table defines whether any > > HW programming is actually needed. > > > > Signed-off-by: Stephen Warren <swarren@nvidia.com> > > This is equivalent to providing dummy pincontrollers as was on my > TODO for a while admittedly. > > For consistency with regulators it would maybe be better to have > optional dummy pin controllers but after thinking a bit about it > I think this is more helpful, so I applied it anyway. > > However I would invite more opinions... > I'm afraid this is a little error-prone, that means even we specifed the wrong map name or state name, the pinctrl_get still does not get failed and it is a little different as what we want in this patch.
Regards Dong Aisheng
| |