Messages in this thread | | | Date | Thu, 23 Feb 2012 11:48:06 +0800 | From | Dong Aisheng <> | Subject | Re: [PATCH 11/20] pinctrl: Downgrade pinctrl_get warning when no maps are found |
| |
On Wed, Feb 22, 2012 at 09:21:25AM -0800, Stephen Warren wrote: ... > > I'm afraid this is a little error-prone, that means even we specifed > > the wrong map name or state name, the pinctrl_get still does not get > > failed and it is a little different as what we want in this patch. > > Yes, this does open up a small opportunity for an undetected error at > this stage in the patch series. > > However, this is closed later by the final patch that enhances the mapping > table to represent pin config data, and "dummy" states. > > I wrote/posted this patch to highlight that this code should be checking > for non-existent states, rather than states which match no mapping table > entries. Admittedly, there's no way to represent the difference at this > point in the patch series. Once the final patch is applied, there's an > explicit way to represent a state that exists, but has no mapping table > entries, so the opportunity for error then no longer exists. > Ok, it's good. Will see your final patch for this issue.
Regards Dong Aisheng
| |