lkml.org 
[lkml]   [2012]   [Feb]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 04/20] pinctrl: Record a pin owner, not mux function, when requesting pins
    From
    On Mon, Feb 20, 2012 at 7:45 AM, Stephen Warren <swarren@nvidia.com> wrote:

    > When pins are requested/acquired/got, some device becomes the owner of
    > their mux setting. At this point, it isn't certain which mux function
    > will be selected for the pin, since this may vary between each of the
    > device's states in the pinctrl mapping table. As such, we should record
    > the owning device, not what we think the initial mux setting will be,
    > when requesting pins.
    >
    > This doesn't make a lot of difference right now since pinctrl_get gets
    > only one single device/state combination, but this will make a difference
    > when pinctrl_get gets all states, and pinctrl_select_state can switch
    > between states.
    >
    > Signed-off-by: Stephen Warren <swarren@nvidia.com>

    Mostly a rename then, OK...

    > @@ -66,19 +65,14 @@ static int pin_request(struct pinctrl_dev *pctldev,
    >                goto out;
    >        }
    >
    > -       if (!function) {
    > -               dev_err(pctldev->dev, "no function name given\n");
    > -               return -EINVAL;
    > -       }
    > -

    Why should it be allowed to have a NULL owner? There is a
    debug print involving it above but ... maybe this is over-cautious?

    Yours,
    Linus Walleij
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2012-02-20 22:17    [W:0.033 / U:0.252 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site