Messages in this thread | | | Date | Wed, 22 Feb 2012 07:13:43 +0100 | Subject | Re: [PATCH 08/20] pinctrl: Assume map table entries can't have a NULL name field | From | Linus Walleij <> |
| |
On Tue, Feb 21, 2012 at 6:46 PM, Stephen Warren <swarren@nvidia.com> wrote:
> I guess we could just modify pinmux_get() such that if NULL is passed as > the state name, it uses "default" instead internally. The disadvantage I > see here is that someone reading the client driver and writing the mapping > table then has to know that pinmux_get() does that internally, rather than > it being obvious right in the client driver code.
I would prefer this solution, it has the upside of not needing to touch the sirf driver.
And please #define the string somewhere instead of open-coding "default", it's too errorprone IMO.
Thanks, Linus Walleij
| |