lkml.org 
[lkml]   [2012]   [Feb]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRE: [PATCH 13/20] pinctrl: Error if mapping table's control dev can't be found
Linus Walleij wrote at Tuesday, February 21, 2012 6:59 AM:
> On Mon, Feb 20, 2012 at 7:45 AM, Stephen Warren <swarren@nvidia.com> wrote:
>
> > This is a serious error, and the pin control system will not function
> > correctly if it ends up not programing the mapping table entries into
> > the HW. Instead of just ignoring this, error out.
> >
> > Signed-off-by: Stephen Warren <swarren@nvidia.com>
>
> Thanks applied, this came to bite me today so I see the value
> of being strict here.
>
> > +                       /* Eventually, this should trigger deferred probe */
> > +                       return -ENODEV;
>
> I changed this to ERR_PTR(-ENODEV) in my codebase as
> it returns a pointer.

Thanks. I thought I'd fixed that up after compiling each patch individually,
but I guess I missed one:-(

--
nvpublic

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2012-02-21 18:53    [W:0.505 / U:0.000 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site