Messages in this thread | | | Date | Tue, 26 Feb 2008 11:56:27 -0600 | From | Paul Jackson <> | Subject | Re: [patch 3/6] mempolicy: add MPOL_F_STATIC_NODES flag |
| |
> return do_mbind(start, len, mode, mode_flags, &nodes, flags);
The intermingling of 'flags', 'mode' and 'mode_flags' to refer to the low bits, the high bits or all the bits of the flags field is handled fairly carefully in your patch, but can still be a bit difficult to keep track of which is which when reading.
I'll wager not many readers can immediately say what the 'mode', 'mode_flags' and 'flags' refer to, in the above code snippet, for example.
Do you have any suggestions on how to further improve the clarity of this code?
-- I won't rest till it's the best ... Programmer, Linux Scalability Paul Jackson <pj@sgi.com> 1.940.382.4214
| |