| Date | Wed, 3 Apr 2024 12:08:55 +0300 | From | Andy Shevchenko <> | Subject | Re: [PATCH 03/34] platform: goldfish: remove ACPI_PTR() annotations |
| |
On Wed, Apr 03, 2024 at 10:06:21AM +0200, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@arndb.de> > > On platforms without ACPI support, this causes a W=1 warning from gcc when > the driver is built-in: > > drivers/platform/goldfish/goldfish_pipe.c:925:36: warning: 'goldfish_pipe_acpi_match' defined but not used [-Wunused-const-variable=] > 925 | static const struct acpi_device_id goldfish_pipe_acpi_match[] = { > | ^~~~~~~~~~~~~~~~~~~~~~~~ > > There is no real harm in just keeping the small table around, so rather > than adding more #ifdef checks, just reference it unconditionally to avoid > the warning.
With this change you also may replace acpi.h by mod_devicetable.h. Please, also check all other conversions that you may replace of*.h/acpi.h by a proper one, i.e. mod_devicetable.h.
When addressed, this one Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
-- With Best Regards, Andy Shevchenko
|