Messages in this thread | | | Date | Wed, 03 Apr 2024 17:50:23 +0200 | From | "Arnd Bergmann" <> | Subject | Re: [PATCH 24/34] crypto: ccp - drop platform ifdef checks |
| |
On Wed, Apr 3, 2024, at 17:17, Tom Lendacky wrote: > On 4/3/24 03:06, Arnd Bergmann wrote: >> From: Arnd Bergmann <arnd@arndb.de> >> >> When both ACPI and OF are disabled, the dev_vdata variable is unused: >> >> drivers/crypto/ccp/sp-platform.c:33:34: error: unused variable 'dev_vdata' [-Werror,-Wunused-const-variable] >> >> This is not a useful configuration, and there is not much point in saving >> a few bytes when only one of the two is enabled, so just remove all >> these ifdef checks and rely on of_match_node() and acpi_match_device() >> returning NULL when these subsystems are disabled. >> >> Fixes: 6c5063434098 ("crypto: ccp - Add ACPI support") >> Signed-off-by: Arnd Bergmann <arnd@arndb.de> > > Would using __maybe_unused on dev_vdata be the safer, easier choice?
It's a simpler change, but leaves the extra complexity that is not needed here.
Arnd
| |