lkml.org 
[lkml]   [2024]   [Apr]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 22/34] drm/komeda: don't warn for unused debugfs files
    Date
    From: Arnd Bergmann <arnd@arndb.de>

    With debugfs disabled, the komeda_register debugfs file is unused:

    drivers/gpu/drm/arm/display/komeda/komeda_dev.c:44:1: error: unused variable 'komeda_register_fops' [-Werror,-Wunused-const-variable]
    DEFINE_SHOW_ATTRIBUTE(komeda_register);

    The komeda_debugfs_init() function already has a call to debugfs_initialized()
    that ends up eliminating the file as dead code, so just drop the #ifdef
    to get rid of the warning.

    Fixes: 576832681891 ("arm/komeda: Compile komeda_debugfs_init() only if CONFIG_DEBUG_FS is enabled")
    Fixes: 7d3cfb70a604 ("drm/komeda: Add debugfs node "register" for register dump")
    Signed-off-by: Arnd Bergmann <arnd@arndb.de>
    ---
    drivers/gpu/drm/arm/display/komeda/komeda_dev.c | 8 --------
    1 file changed, 8 deletions(-)

    diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c b/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
    index 14ee79becacb..5ba62e637a61 100644
    --- a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
    +++ b/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
    @@ -12,10 +12,8 @@
    #include <linux/platform_device.h>
    #include <linux/pm_runtime.h>
    #include <linux/dma-mapping.h>
    -#ifdef CONFIG_DEBUG_FS
    #include <linux/debugfs.h>
    #include <linux/seq_file.h>
    -#endif

    #include <drm/drm_print.h>

    @@ -43,7 +41,6 @@ static int komeda_register_show(struct seq_file *sf, void *x)

    DEFINE_SHOW_ATTRIBUTE(komeda_register);

    -#ifdef CONFIG_DEBUG_FS
    static void komeda_debugfs_init(struct komeda_dev *mdev)
    {
    if (!debugfs_initialized())
    @@ -55,7 +52,6 @@ static void komeda_debugfs_init(struct komeda_dev *mdev)
    debugfs_create_x16("err_verbosity", 0664, mdev->debugfs_root,
    &mdev->err_verbosity);
    }
    -#endif

    static ssize_t
    core_id_show(struct device *dev, struct device_attribute *attr, char *buf)
    @@ -265,9 +261,7 @@ struct komeda_dev *komeda_dev_create(struct device *dev)

    mdev->err_verbosity = KOMEDA_DEV_PRINT_ERR_EVENTS;

    -#ifdef CONFIG_DEBUG_FS
    komeda_debugfs_init(mdev);
    -#endif

    return mdev;

    @@ -286,9 +280,7 @@ void komeda_dev_destroy(struct komeda_dev *mdev)

    sysfs_remove_group(&dev->kobj, &komeda_sysfs_attr_group);

    -#ifdef CONFIG_DEBUG_FS
    debugfs_remove_recursive(mdev->debugfs_root);
    -#endif

    if (mdev->aclk)
    clk_prepare_enable(mdev->aclk);
    --
    2.39.2

    \
     
     \ /
      Last update: 2024-05-27 16:20    [W:4.880 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site