lkml.org 
[lkml]   [2024]   [Apr]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 16/34] iio: ad5755: hook up of_device_id lookup to platform driver
    On Wed, Apr 03, 2024 at 10:06:34AM +0200, Arnd Bergmann wrote:
    > From: Arnd Bergmann <arnd@arndb.de>
    >
    > When the driver is built-in, 'make W=1' warns about an unused
    > ID table:
    >
    > drivers/iio/dac/ad5755.c:866:34: error: 'ad5755_of_match' defined but not used [-Werror=unused-const-variable=]
    > 866 | static const struct of_device_id ad5755_of_match[] = {
    >
    > While the data is duplicated in the spi_device_id, it's common
    > to use the actual OF compatible strings in the driver.
    >
    > Since there are no in-tree users of plain platform devices, the
    > spi_device_id table could actually be dropped entirely with this.

    Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

    --
    With Best Regards,
    Andy Shevchenko



    \
     
     \ /
      Last update: 2024-05-27 16:20    [W:6.729 / U:0.048 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site