| From | Linus Walleij <> | Date | Fri, 5 Mar 2021 11:25:19 +0100 | Subject | Re: [RFT PATCH v3 10/27] docs: driver-api: device-io: Document ioremap() variants & access funcs |
| |
On Thu, Mar 4, 2021 at 10:40 PM Hector Martin <marcan@marcan.st> wrote:
> This documents the newly introduced ioremap_np() along with all the > other common ioremap() variants, and some higher-level abstractions > available. > > Signed-off-by: Hector Martin <marcan@marcan.st>
I like this, I just want one change:
Put the common ioremap() on top in all paragraphs, so the norm comes before the exceptions.
I.e. it is weird to mention ioremap_np() before mentioning ioremap().
With that change: Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours, Linus Walleij
|