lkml.org 
[lkml]   [2021]   [Mar]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [RFT PATCH v3 18/27] tty: serial: samsung_tty: Separate S3C64XX ops structure
    From
    Date
    On 04/03/2021 22:38, Hector Martin wrote:
    > Instead of patching a single global ops structure depending on the port
    > type, use a separate s3c64xx_serial_ops for the S3C64XX type. This
    > allows us to mark the structures as const.
    >
    > Also split out s3c64xx_serial_shutdown into a separate function now that
    > we have a separate ops structure; this avoids excessive branching
    > control flow and mirrors s3c64xx_serial_startup. tx_claimed and
    > rx_claimed are only used in the S3C24XX functions.
    >
    > Signed-off-by: Hector Martin <marcan@marcan.st>
    > ---
    > drivers/tty/serial/samsung_tty.c | 71 ++++++++++++++++++++++++--------
    > 1 file changed, 54 insertions(+), 17 deletions(-)


    Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
    Tested-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>

    Best regards,
    Krzysztof

    \
     
     \ /
      Last update: 2021-03-05 11:32    [W:2.638 / U:0.168 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site