Messages in this thread | | | Subject | Re: [RFT PATCH v3 18/27] tty: serial: samsung_tty: Separate S3C64XX ops structure | From | Krzysztof Kozlowski <> | Date | Fri, 5 Mar 2021 11:30:29 +0100 |
| |
On 04/03/2021 22:38, Hector Martin wrote: > Instead of patching a single global ops structure depending on the port > type, use a separate s3c64xx_serial_ops for the S3C64XX type. This > allows us to mark the structures as const. > > Also split out s3c64xx_serial_shutdown into a separate function now that > we have a separate ops structure; this avoids excessive branching > control flow and mirrors s3c64xx_serial_startup. tx_claimed and > rx_claimed are only used in the S3C24XX functions. > > Signed-off-by: Hector Martin <marcan@marcan.st> > --- > drivers/tty/serial/samsung_tty.c | 71 ++++++++++++++++++++++++-------- > 1 file changed, 54 insertions(+), 17 deletions(-)
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> Tested-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Best regards, Krzysztof
| |