lkml.org 
[lkml]   [2021]   [Mar]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [RFT PATCH v3 10/27] docs: driver-api: device-io: Document ioremap() variants & access funcs
    On Fri, Mar 5, 2021 at 12:25 PM Linus Walleij <linus.walleij@linaro.org> wrote:
    > On Thu, Mar 4, 2021 at 10:40 PM Hector Martin <marcan@marcan.st> wrote:
    >
    > > This documents the newly introduced ioremap_np() along with all the
    > > other common ioremap() variants, and some higher-level abstractions
    > > available.
    > >
    > > Signed-off-by: Hector Martin <marcan@marcan.st>
    >
    > I like this, I just want one change:
    >
    > Put the common ioremap() on top in all paragraphs, so the norm
    > comes before the exceptions.
    >
    > I.e. it is weird to mention ioremap_np() before mentioning ioremap().

    +1 here. That is what I have stumbled upon reading carefully.

    --
    With Best Regards,
    Andy Shevchenko

    \
     
     \ /
      Last update: 2021-03-05 16:10    [W:3.717 / U:0.092 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site