| Date | Wed, 26 Aug 2020 22:13:34 +0300 | From | Andy Shevchenko <> | Subject | Re: [PATCH 02/24] Input: gpio_keys - Simplify with dev_err_probe() |
| |
On Wed, Aug 26, 2020 at 08:16:44PM +0200, Krzysztof Kozlowski wrote: > Common pattern of handling deferred probe can be simplified with > dev_err_probe(). Less code and also it prints the error value.
> --- a/drivers/input/keyboard/gpio_keys.c > +++ b/drivers/input/keyboard/gpio_keys.c > @@ -505,10 +505,7 @@ static int gpio_keys_setup_key(struct platform_device *pdev, > */ > bdata->gpiod = NULL;
gpiod_get_optional()? Do not see much context though (but please double check your series for these kind of things).
> } else { > - if (error != -EPROBE_DEFER) > - dev_err(dev, "failed to get gpio: %d\n", > - error); > - return error; > + return dev_err_probe(dev, error, "failed to get gpio\n"); > } > } > } else if (gpio_is_valid(button->gpio)) {
-- With Best Regards, Andy Shevchenko
|