lkml.org 
[lkml]   [2020]   [Aug]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 17/24] Input: melfas_mip4 - Simplify with dev_err_probe()
    Date
    Common pattern of handling deferred probe can be simplified with
    dev_err_probe(). Less code and also it prints the error value.

    Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
    ---
    drivers/input/touchscreen/melfas_mip4.c | 9 ++-------
    1 file changed, 2 insertions(+), 7 deletions(-)

    diff --git a/drivers/input/touchscreen/melfas_mip4.c b/drivers/input/touchscreen/melfas_mip4.c
    index f67efdd040b2..d43a8643adcd 100644
    --- a/drivers/input/touchscreen/melfas_mip4.c
    +++ b/drivers/input/touchscreen/melfas_mip4.c
    @@ -1451,13 +1451,8 @@ static int mip4_probe(struct i2c_client *client, const struct i2c_device_id *id)

    ts->gpio_ce = devm_gpiod_get_optional(&client->dev,
    "ce", GPIOD_OUT_LOW);
    - if (IS_ERR(ts->gpio_ce)) {
    - error = PTR_ERR(ts->gpio_ce);
    - if (error != EPROBE_DEFER)
    - dev_err(&client->dev,
    - "Failed to get gpio: %d\n", error);
    - return error;
    - }
    + if (IS_ERR(ts->gpio_ce))
    + return dev_err_probe(&client->dev, PTR_ERR(ts->gpio_ce), "Failed to get gpio\n");

    error = mip4_power_on(ts);
    if (error)
    --
    2.17.1
    \
     
     \ /
      Last update: 2020-08-26 20:19    [W:4.114 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site