lkml.org 
[lkml]   [2020]   [Aug]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 21/24] Input: silead - Simplify with dev_err_probe()
    Date
    Common pattern of handling deferred probe can be simplified with
    dev_err_probe(). Less code and also it prints the error value.

    Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
    ---
    drivers/input/touchscreen/silead.c | 8 +++-----
    1 file changed, 3 insertions(+), 5 deletions(-)

    diff --git a/drivers/input/touchscreen/silead.c b/drivers/input/touchscreen/silead.c
    index 8fa2f3b7cfd8..754debb4b2c4 100644
    --- a/drivers/input/touchscreen/silead.c
    +++ b/drivers/input/touchscreen/silead.c
    @@ -512,11 +512,9 @@ static int silead_ts_probe(struct i2c_client *client,

    /* Power GPIO pin */
    data->gpio_power = devm_gpiod_get_optional(dev, "power", GPIOD_OUT_LOW);
    - if (IS_ERR(data->gpio_power)) {
    - if (PTR_ERR(data->gpio_power) != -EPROBE_DEFER)
    - dev_err(dev, "Shutdown GPIO request failed\n");
    - return PTR_ERR(data->gpio_power);
    - }
    + if (IS_ERR(data->gpio_power))
    + return dev_err_probe(dev, PTR_ERR(data->gpio_power),
    + "Shutdown GPIO request failed\n");

    error = silead_ts_setup(client);
    if (error)
    --
    2.17.1
    \
     
     \ /
      Last update: 2020-08-26 20:20    [W:3.185 / U:1.124 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site