lkml.org 
[lkml]   [2020]   [Aug]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 14/24] Input: ektf2127 - Simplify with dev_err_probe()
    Date
    Common pattern of handling deferred probe can be simplified with
    dev_err_probe(). Less code and also it prints the error value.

    Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
    ---
    drivers/input/touchscreen/ektf2127.c | 8 ++------
    1 file changed, 2 insertions(+), 6 deletions(-)

    diff --git a/drivers/input/touchscreen/ektf2127.c b/drivers/input/touchscreen/ektf2127.c
    index eadd389cf81f..cd41483cfae5 100644
    --- a/drivers/input/touchscreen/ektf2127.c
    +++ b/drivers/input/touchscreen/ektf2127.c
    @@ -237,12 +237,8 @@ static int ektf2127_probe(struct i2c_client *client,

    /* This requests the gpio *and* turns on the touchscreen controller */
    ts->power_gpios = devm_gpiod_get(dev, "power", GPIOD_OUT_HIGH);
    - if (IS_ERR(ts->power_gpios)) {
    - error = PTR_ERR(ts->power_gpios);
    - if (error != -EPROBE_DEFER)
    - dev_err(dev, "Error getting power gpio: %d\n", error);
    - return error;
    - }
    + if (IS_ERR(ts->power_gpios))
    + return dev_err_probe(dev, PTR_ERR(ts->power_gpios), "Error getting power gpio\n");

    input = devm_input_allocate_device(dev);
    if (!input)
    --
    2.17.1
    \
     
     \ /
      Last update: 2020-08-26 20:19    [W:4.021 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site