| Date | Tue, 13 Aug 2019 17:27:14 +0200 | From | Greg KH <> | Subject | Re: [PATCH v2 04/10] modpost: add support for symbol namespaces |
| |
On Tue, Aug 13, 2019 at 01:17:01PM +0100, Matthias Maennich wrote: > Add support for symbols that are exported into namespaces. For that, > extract any namespace suffix from the symbol name. In addition, emit a > warning whenever a module refers to an exported symbol without > explicitly importing the namespace that it is defined in. This patch > consistently adds the namespace suffix to symbol names exported into > Module.symvers. > > Example warning emitted by modpost in case of the above violation: > > WARNING: module ums-usbat uses symbol usb_stor_resume from namespace > USB_STORAGE, but does not import it. > > Co-developed-by: Martijn Coenen <maco@android.com> > Signed-off-by: Martijn Coenen <maco@android.com> > Reviewed-by: Joel Fernandes (Google) <joel@joelfernandes.org> > Signed-off-by: Matthias Maennich <maennich@google.com> > --- > scripts/mod/modpost.c | 91 +++++++++++++++++++++++++++++++++++++------ > scripts/mod/modpost.h | 7 ++++ > 2 files changed, 87 insertions(+), 11 deletions(-)
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|