Messages in this thread | | | Date | Wed, 21 Aug 2019 16:36:55 +0200 | From | Jessica Yu <> | Subject | Re: [PATCH v3 10/11] RFC: usb-storage: export symbols in USB_STORAGE namespace |
| |
+++ Greg KH [21/08/19 05:38 -0700]: >On Wed, Aug 21, 2019 at 12:49:25PM +0100, Matthias Maennich wrote: >> Modules using these symbols are required to explicitly import the >> namespace. This patch was generated with the following steps and serves >> as a reference to use the symbol namespace feature: >> >> 1) Define DEFAULT_SYMBOL_NAMESPACE in the corresponding Makefile >> 2) make (see warnings during modpost about missing imports) >> 3) make nsdeps >> >> Instead of a DEFAULT_SYMBOL_NAMESPACE definition, the EXPORT_SYMBOL_NS >> variants can be used to explicitly specify the namespace. The advantage >> of the method used here is that newly added symbols are automatically >> exported and existing ones are exported without touching their >> respective EXPORT_SYMBOL macro expansion. >> >> Signed-off-by: Matthias Maennich <maennich@google.com> > >This looks good to me. This can be included with the rest of this >series when/if it goes through the kbuild or module tree: > >Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > >Actually, which tree will this be going through?
I would be happy to take the patchset through the modules tree once it collects the appropriate ack/reviewed-by's and once I get a chance to sit down and review/test it next week :)
Thanks!
Jessica
| |