lkml.org 
[lkml]   [2019]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [v2 08/10] scripts: Coccinelle script for namespace dependencies
From
Date
> +generate_deps_for_ns() {
> + $SPATCH --very-quiet --in-place --sp-file \
> + $srctree/scripts/coccinelle/misc/add_namespace.cocci -D ns=$1 $2
> +}

* Where will the variable “srctree” be set for the file “scripts/nsdeps”?

* Would you like to support a separate build directory for desired adjustments?

* How do you think about to check error handling around such commands?


> +generate_deps() {

> + for source_file in $mod_source_files; do
> + sed '/MODULE_IMPORT_NS/Q' $source_file > ${source_file}.tmp


I suggest to assign the name for the temporary file to a variable
which should be used by subsequent commands.

Regards,
Markus

\
 
 \ /
  Last update: 2019-08-15 15:56    [W:0.342 / U:12.444 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site