lkml.org 
[lkml]   [2019]   [Aug]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 09/10] usb-storage: remove single-use define for debugging
On Tue, Aug 13, 2019 at 01:17:06PM +0100, Matthias Maennich wrote:
> USB_STORAGE was defined as "usb-storage: " and used in a single location
> as argument to printk. In order to be able to use the name
> 'USB_STORAGE', drop the definition and use the string directly for the
> printk call.
>
> Signed-off-by: Matthias Maennich <maennich@google.com>
> ---
> drivers/usb/storage/debug.h | 2 --
> drivers/usb/storage/scsiglue.c | 2 +-
> 2 files changed, 1 insertion(+), 3 deletions(-)

I'll go take this today. The module really should just be using
dev_err() there. It needs to be cleaned up :(

thanks,

greg k-h

\
 
 \ /
  Last update: 2019-08-13 14:43    [W:0.230 / U:11.268 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site