lkml.org 
[lkml]   [2015]   [Apr]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/6] phy: twl4030-usb: add ABI documentation
On Sat, 18 Apr 2015 00:14:36 +0200 Pavel Machek <pavel@ucw.cz> wrote:

> On Thu 2015-04-16 18:03:04, NeilBrown wrote:
> > From: NeilBrown <neilb@suse.de>
> >
> > This driver device one local attribute: vbus.
> > Describe that in Documentation/ABI/testing/sysfs-platform/twl4030-usb.
> >
> > Signed-off-by: NeilBrown <neil@brown.name>
> > ---
> > .../ABI/testing/sysfs-platform-twl4030-usb | 8 ++++++++
> > 1 file changed, 8 insertions(+)
> > create mode 100644 Documentation/ABI/testing/sysfs-platform-twl4030-usb
> >
> > diff --git a/Documentation/ABI/testing/sysfs-platform-twl4030-usb b/Documentation/ABI/testing/sysfs-platform-twl4030-usb
> > new file mode 100644
> > index 000000000000..512c51be64ae
> > --- /dev/null
> > +++ b/Documentation/ABI/testing/sysfs-platform-twl4030-usb
> > @@ -0,0 +1,8 @@
> > +What: /sys/bus/platform/devices/*twl4030-usb/vbus
> > +Description:
> > + Read-only status reporting if VBUS (approx 5V)
> > + is being supplied by the USB bus.
> > +
> > + Possible values: "on", "off".
>
> Would bit be better to have values "0" and "1"? Kernel usually does
> that for booleans...

1/ The code already uses "on" and "off", so changing would be an ABI
breakage.

2/ No it doesn't.
For modules params, the kernel uses "Y" and "N"

git grep '? "on" : "off"' | wc

find 172 matches.

NeilBrown
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2015-04-18 00:41    [W:0.145 / U:24.880 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site