lkml.org 
[lkml]   [2015]   [Apr]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3/6] phy: twl4030-usb: remove incorrect pm_runtime_get_sync() in probe function.
    The USB phy should initialize with power-off, and will be powered on
    by the USB system when a cable connection is detected.

    Having this pm_runtime_get_sync() during probe causes the phy to
    *always* be powered on.
    Removing it returns to sensible power management.

    Fixes: 96be39ab34b77c6f6f5cd6ae03aac6c6449ee5c4
    Signed-off-by: NeilBrown <neil@brown.name>
    ---
    drivers/phy/phy-twl4030-usb.c | 1 -
    1 file changed, 1 deletion(-)

    diff --git a/drivers/phy/phy-twl4030-usb.c b/drivers/phy/phy-twl4030-usb.c
    index 590c2b1c1a94..3a707dd14238 100644
    --- a/drivers/phy/phy-twl4030-usb.c
    +++ b/drivers/phy/phy-twl4030-usb.c
    @@ -715,7 +715,6 @@ static int twl4030_usb_probe(struct platform_device *pdev)
    pm_runtime_use_autosuspend(&pdev->dev);
    pm_runtime_set_autosuspend_delay(&pdev->dev, 2000);
    pm_runtime_enable(&pdev->dev);
    - pm_runtime_get_sync(&pdev->dev);

    /* Our job is to use irqs and status from the power module
    * to keep the transceiver disabled when nothing's connected.



    \
     
     \ /
      Last update: 2015-04-16 10:41    [W:4.442 / U:0.052 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site