| Subject | Re: [PATCH v3 41/77] ncr5380: Replace redundant flags with FLAG_NO_DMA_FIXUP | From | Hannes Reinecke <> | Date | Tue, 22 Dec 2015 08:39:07 +0100 |
| |
On 12/22/2015 02:18 AM, Finn Thain wrote: > The flags DMA_WORKS_RIGHT, FLAG_NCR53C400 and FLAG_HAS_LAST_BYTE_SENT > all mean the same thing, i.e. the chip is not a 538[01]. (More recent > devices such as the 53C80 have a 'Last Byte Sent' bit in the Target > Command Register as well as other fixes for End-of-DMA errata.) > > These flags have no additional meanings since previous cleanup patches > eliminated the NCR53C400 macro, moved g_NCR5380-specific code out of the > core driver and standardized interrupt handling. > > Use the FLAG_NO_DMA_FIXUP flag to suppress End-of-DMA errata workarounds, > for those cards and drivers that make use of the TCR_LAST_BYTE_SENT bit. > Remove the old flags. > > Signed-off-by: Finn Thain <fthain@telegraphics.com.au> > > --- > drivers/scsi/NCR5380.c | 68 +++++++++++++++-------------------------------- > drivers/scsi/NCR5380.h | 4 -- > drivers/scsi/dtc.c | 4 -- > drivers/scsi/g_NCR5380.c | 2 - > 4 files changed, 25 insertions(+), 53 deletions(-) > Reviewed-by: Hannes Reinecke <hare@suse.com>
Cheers,
Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
|