lkml.org 
[lkml]   [2015]   [Dec]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v3 57/77] ncr5380: Use standard list data structure
    From
    Date
    On 12/22/2015 02:18 AM, Finn Thain wrote:
    > The NCR5380 drivers have a home-spun linked list implementation for
    > scsi_cmnd structs that uses cmd->host_scribble as a 'next' pointer. Adopt
    > the standard list_head data structure and list operations instead. Remove
    > the eh_abort_handler rather than convert it. Doing the conversion would
    > only be churn because the existing EH handlers don't work and get replaced
    > in a subsequent patch.
    >
    > Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
    >
    > ---
    >
    > Changed since v2:
    > - Fix NULL pointer dereference in NCR5380_reselect() when SUPPORT_TAGS is
    > enabled in the atari_NCR5380.c core driver.
    >
    Well, using ->host_scribble allows for an easy check on the midlayer if
    a command has been properly released by the LLDD. But that's just a
    side-note.

    Reviewed-by: Hannes Reinecke <hare@suse.com>

    Cheers,

    Hannes
    --
    Dr. Hannes Reinecke zSeries & Storage
    hare@suse.de +49 911 74053 688
    SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
    GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)


    \
     
     \ /
      Last update: 2015-12-22 09:21    [W:3.992 / U:0.800 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site