| Subject | Re: [PATCH v3 30/77] ncr5380: Add missing break after case MESSAGE_REJECT | From | Hannes Reinecke <> | Date | Tue, 22 Dec 2015 08:26:02 +0100 |
| |
On 12/22/2015 02:18 AM, Finn Thain wrote: > MESSAGE REJECT does not imply DISCONNECT: the target is about to enter > MESSAGE IN or MESSAGE OUT phase. > > This bug fix comes from atari_NCR5380.c. Unfortunately it never made it > into the original NCR5380.c core driver. > > Signed-off-by: Finn Thain <fthain@telegraphics.com.au> > > --- > drivers/scsi/NCR5380.c | 1 + > 1 file changed, 1 insertion(+) > > Index: linux/drivers/scsi/NCR5380.c > =================================================================== > --- linux.orig/drivers/scsi/NCR5380.c 2015-12-22 12:16:16.000000000 +1100 > +++ linux/drivers/scsi/NCR5380.c 2015-12-22 12:16:17.000000000 +1100 > @@ -1990,6 +1990,7 @@ static void NCR5380_information_transfer > default: > break; > } > + break; > case DISCONNECT:{ > /* Accept message by clearing ACK */ > NCR5380_write(INITIATOR_COMMAND_REG, ICR_BASE); > > Reviewed-by: Hannes Reinecke <hare@suse.com>
Cheers,
Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
|