lkml.org 
[lkml]   [2015]   [Dec]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH v3 13/77] ncr5380: Remove redundant register writes
    Remove the duplicate write to the Select Enable Register that appeared
    in v1.1.38.

    Also remove the redundant write to Initiator Command Register prior to
    calling do_abort().

    Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
    Reviewed-by: Hannes Reinecke <hare@suse.com>

    ---
    drivers/scsi/NCR5380.c | 2 --
    drivers/scsi/atari_NCR5380.c | 3 ---
    2 files changed, 5 deletions(-)

    Index: linux/drivers/scsi/NCR5380.c
    ===================================================================
    --- linux.orig/drivers/scsi/NCR5380.c 2015-12-22 12:15:44.000000000 +1100
    +++ linux/drivers/scsi/NCR5380.c 2015-12-22 12:15:46.000000000 +1100
    @@ -1384,7 +1384,6 @@ part2:
    cmd->scsi_done(cmd);
    NCR5380_write(SELECT_ENABLE_REG, hostdata->id_mask);
    dprintk(NDEBUG_SELECTION, "scsi%d : target did not respond within 250ms\n", instance->host_no);
    - NCR5380_write(SELECT_ENABLE_REG, hostdata->id_mask);
    return 0;
    }
    hostdata->targets_present |= (1 << scmd_id(cmd));
    @@ -2076,7 +2075,6 @@ static void NCR5380_information_transfer
    scmd_printk(KERN_INFO, cmd,
    "switching to slow handshake\n");
    cmd->device->borken = 1;
    - NCR5380_write(INITIATOR_COMMAND_REG, ICR_BASE | ICR_ASSERT_ATN);
    sink = 1;
    do_abort(instance);
    cmd->result = DID_ERROR << 16;
    Index: linux/drivers/scsi/atari_NCR5380.c
    ===================================================================
    --- linux.orig/drivers/scsi/atari_NCR5380.c 2015-12-22 12:15:44.000000000 +1100
    +++ linux/drivers/scsi/atari_NCR5380.c 2015-12-22 12:15:46.000000000 +1100
    @@ -1640,7 +1640,6 @@ static int NCR5380_select(struct Scsi_Ho
    cmd->scsi_done(cmd);
    NCR5380_write(SELECT_ENABLE_REG, hostdata->id_mask);
    dprintk(NDEBUG_SELECTION, "scsi%d: target did not respond within 250ms\n", HOSTNO);
    - NCR5380_write(SELECT_ENABLE_REG, hostdata->id_mask);
    return 0;
    }

    @@ -2192,8 +2191,6 @@ static void NCR5380_information_transfer
    scmd_printk(KERN_INFO, cmd,
    "switching to slow handshake\n");
    cmd->device->borken = 1;
    - NCR5380_write(INITIATOR_COMMAND_REG, ICR_BASE |
    - ICR_ASSERT_ATN);
    sink = 1;
    do_abort(instance);
    cmd->result = DID_ERROR << 16;



    \
     
     \ /
      Last update: 2015-12-22 04:21    [W:3.571 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site