lkml.org 
[lkml]   [2015]   [Nov]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 6/9] rtc-pcf2123: avoid resetting the clock if possible
On 04/11/2015 at 07:36:37 -0800, Joshua Clayton wrote :
> + ret = pcf2123_rtc_read_time(dev, &tm);
> + if (ret < 0)
> + return false;
> +
> + if (rtc_valid_tm(&tm) < 0) {
> + dev_err(dev, "retrieved date/time is not valid.\n");
> + return false;
> + }
> +

I would remove that test as basically, the date/time will only be valid
when OSC_HAS_STOPPED is not set.

--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com


\
 
 \ /
  Last update: 2015-11-25 00:41    [W:0.424 / U:0.564 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site