Messages in this thread | | | Date | Tue, 1 Dec 2015 10:22:03 -0800 | From | Joshua Clayton <> | Subject | Re: [PATCH 5/9] rtc-pcf2123: put the chip reset into a function |
| |
On Wed, 25 Nov 2015 00:17:36 +0100 Alexandre Belloni <alexandre.belloni@free-electrons.com> wrote:
> On 04/11/2015 at 07:36:36 -0800, Joshua Clayton wrote : > > A commit message, even when simple is mandatory. > Sorry about that. I know better. will fix for v2
> > + /* See if the counter was actually stopped */ > > + dev_dbg(dev, "checking for presence of RTC\n"); > > + ret = pcf2123_read(dev, PCF2123_REG_CTRL1, rxbuf, > > sizeof(rxbuf)); > > + if (ret < 0) > > + return ret; > > + > > + dev_dbg(dev, "received data from RTC (0x%02X 0x%02X)\n", > > + rxbuf[0], rxbuf[1]); > > This is not properly aligned (use checkpatch --strict) > > Will fix.
| |