Messages in this thread | | | From | Joshua Clayton <> | Subject | Re: [PATCH 0/9] rtc-2123: access the clock offset feature | Date | Wed, 18 Nov 2015 16:25:14 -0800 |
| |
On Tuesday, November 17, 2015 05:25:30 PM Alexandre Belloni wrote: > On 17/11/2015 at 07:30:48 -0800, Joshua Clayton wrote : > > On Wednesday, November 04, 2015 07:36:31 AM Joshua Clayton wrote: > > Any comments on this series? > > I realize now that I submitted it during the merge window, so it may have been overlooked. > > > > I will have a few comments but I didn't review everything thoroughly > yet. As you mentioned, you submitted during the merge window so this was > not going to be in 4.4 anyway. > > Thanks! I can relax since I know it is on your radar. I have responded my self to a couple of fat fingers in the commit messages. I am also in the process of testing the actual effects of the feature.
One thing I'm not sure I have adequately described (and didn't really understand until I started testing) is that a positive value in the adjust register increases the average value of a second, so it makes the clock slower, while a negative adjustment makes it faster.
This was counterintuitive to me. Not having deeply examined other rtc's with similar capabilities, I can't say whether this is the norm.
-- ~Joshua Clayton
| |