lkml.org 
[lkml]   [2014]   [Jul]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 2/4] staging: rtl8192u: Removed unnecessary whitespace & tab warning
On Thu, Jul 10, 2014 at 05:54:55PM +0530, sanjeev sharma wrote:
> From: sanjeev sharma <sanjeev_sharma@mentor.com>
>
> This patch will remove whitespace and tabs reported by
> checkpatch.pl script.
>
> Signed-off-by: Sanjeev Sharma <Sanjeev_Sharma@mentor.com>
> ---
> drivers/staging/rtl8192u/r819xU_phy.c | 23 ++++++++++++-----------
> 1 file changed, 12 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/staging/rtl8192u/r819xU_phy.c b/drivers/staging/rtl8192u/r819xU_phy.c
> index 0bcdd4e..0fcb673 100644
> --- a/drivers/staging/rtl8192u/r819xU_phy.c
> +++ b/drivers/staging/rtl8192u/r819xU_phy.c
> @@ -106,10 +106,10 @@ void rtl8192_setBBreg(struct net_device *dev, u32 reg_addr, u32 bitmask,
> /******************************************************************************
> * function: This function reads specific bits from BB register
> * input: net_device *dev
> - * u32 reg_addr //target addr to be readback
> - * u32 bitmask //taget bit pos to be readback
> - * output: none
> - * return: u32 data //the readback register value
> + * u32 reg_addr //target addr to be readback
> + * u32 bitmask //taget bit pos to be readback
> + * output: none
> + * return: u32 data //the readback register value
> * notice:
> ******************************************************************************/
> u32 rtl8192_QueryBBReg(struct net_device *dev, u32 reg_addr, u32 bitmask)

That doesn't look like you cleaned it up well, it now looks worse.
Please keep the proper indentation of the variables. It's not the
"proper" kernel coding style, but don't make code worse, like you did
here :(

greg k-h


\
 
 \ /
  Last update: 2014-07-13 07:42    [W:0.172 / U:0.336 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site