lkml.org 
[lkml]   [2014]   [Jul]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v2 1/4] staging: rtl8192u: Remove useless return statement in r819xU_phy.c
Date
Thanks Dan,


-----Original Message-----
From: Dan Carpenter [mailto:dan.carpenter@oracle.com]
Sent: Wednesday, July 09, 2014 1:40 PM
To: sanjeev sharma
Cc: gregkh@linuxfoundation.org; devel@driverdev.osuosl.org; peter.senna@gmail.com; linux-kernel@vger.kernel.org; rmfrfs@gmail.com; teobaluta@gmail.com; Sharma, Sanjeev
Subject: Re: [PATCH v2 1/4] staging: rtl8192u: Remove useless return statement in r819xU_phy.c

These patches look ok now. The only thing is that the changelogs are a little off.

On Wed, Jul 09, 2014 at 11:34:17AM +0530, sanjeev sharma wrote:
> From: sanjeev sharma <sanjeev_sharma@mentor.com>

Don't use the From header unless you are sending patches on behalf of someone else. It's better if you can configure your email client so you can send the patches from your @mentor.com address. It would be better if the names were capitalized.

I will take care for future patches and configure email client by using mentor address.

>
> This is a patch to the r819xU_phy.c file that remove unneeded return statements in code.

Please line wrap the changelog at 72 characters (the same as email).
Otherwise Greg sometimes fixes them manually...

But the patches themselves are nice now.

@Greg.,@Dan: Is it Ok if this can be taken care in future.

regards,
dan carpenter



\
 
 \ /
  Last update: 2014-07-09 12:41    [W:0.053 / U:30.280 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site