lkml.org 
[lkml]   [2014]   [Jul]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
SubjectRE: [PATCH v3 4/4] staging: rtl8192u: Fixed too long lines
Date
Hi Joe,

I have incorporated your review comment in version v4.

Regards
Sanjeev Sharma

-----Original Message-----
From: Joe Perches [mailto:joe@perches.com]
Sent: Wednesday, July 09, 2014 6:27 PM
To: sanjeev sharma
Cc: gregkh@linuxfoundation.org; rmfrfs@gmail.com; peter.senna@gmail.com; teobaluta@gmail.com; devel@driverdev.osuosl.org; linux-kernel@vger.kernel.org; Sharma, Sanjeev
Subject: Re: [PATCH v3 4/4] staging: rtl8192u: Fixed too long lines

On Wed, 2014-07-09 at 17:49 +0530, sanjeev sharma wrote:
> This patch will fix too long lines warning reported by checkpatch.pl.

Hi Sanjeev.

> diff --git a/drivers/staging/rtl8192u/r819xU_phy.c
> b/drivers/staging/rtl8192u/r819xU_phy.c
[]
> @@ -1786,7 +1788,9 @@ void InitialGainOperateWorkItemCallBack(struct work_struct *work)
> RT_TRACE(COMP_SCAN, "Scan BBInitialGainRestore 0xa0a is %x\n",
> priv->initgain_backup.cca);
>
> - rtl8192_phy_setTxPower(dev, priv->ieee80211->current_network.channel);
> + rtl8192_phy_setTxPower(dev,
> + priv->ieee80211->current_network.channel
> + );

This one is a little off

+ rtl8192_phy_setTxPower(dev,
+ priv->ieee80211->current_network.channel
+ );

Please align multiline statements to the appropriate open parenthesis using a mix of initial leading tabs followed by the minimal number of spaces required to put the first non-whitespace char at the column immediately after the preceding open paren.

Here it's 4 tabs, 7 spaces, not 5 tabs:

+ rtl8192_phy_setTxPower(dev,
+ priv->ieee80211->current_network.channel);

And please don't use a line that's just a close parenthesis and semicolon.

I think it's better to ignore the 80 column limit for these and place them at the end of the preceding line.



\
 
 \ /
  Last update: 2014-07-10 15:42    [W:0.065 / U:0.820 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site