Messages in this thread | | | From | Andi Kleen <> | Subject | Re: [PATCH 00/19 V2] perf, c2c: Add new tool to analyze cacheline contention on NUMA systems | Date | Fri, 28 Feb 2014 10:57:48 -0800 |
| |
Don Zickus <dzickus@redhat.com> writes: > > A handful of patches include re-enabling MMAP2 support and some fixes > to perf itself.
I would suggest to pursue the lone kernel patch separately. Hopefully that can be merged soon, once the remainin problems with that are addressed.
> > Comemnts, feedback, anything else welcomed.
As a high level comment, can you add support for CSV mode? (-x, in other tools)
I assume most people would data mine the output in some form, and that's much easier with a more machine oriented format.
Also you should probably have the standard perf conventions for output fds (--log-fd, --output, default to stderr). otherwise the output may often be lost.
-Andi
-- ak@linux.intel.com -- Speaking for myself only
| |