Messages in this thread | | | From | Andi Kleen <> | Subject | Re: [PATCH 11/19] perf, c2c: Add in sort on physid | Date | Fri, 28 Feb 2014 10:59:18 -0800 |
| |
Don Zickus <dzickus@redhat.com> writes: > + > + /* > + * must pass period=weight in order to get the correct > + * sorting from hists__collapse_resort() which is solely > + * based on periods. We want sorting be done on nr_events * weight > + * and this is indirectly achieved by passing period=weight here > + * and the he_stat__add_period() function. > + */
sort.c really must be fixed to support multiple sort keys properly. Lots of other code has workarounds for this too (e.g. it is a bit problem for TSX abort weights)
I would suggest to fix that instead of hacking around it.
-Andi
-- ak@linux.intel.com -- Speaking for myself only
| |